nn-models typings fix #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://deploy-preview-840--etna-docs.netlify.app |
Codecov Report
@@ Coverage Diff @@
## master #840 +/- ##
==========================================
- Coverage 84.64% 84.64% -0.01%
==========================================
Files 130 130
Lines 7450 7455 +5
==========================================
+ Hits 6306 6310 +4
- Misses 1144 1145 +1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
martins0n
suggested changes
Aug 10, 2022
| @@ -820,4 +820,70 @@ def get_model(self) -> "DeepBaseNet": | |||
| return self.net | |||
|
|
|||
|
|
|||
| BaseModel = Union[PerSegmentModel, PerSegmentPredictionIntervalModel, MultiSegmentModel, DeepBaseModel] | |||
| class MultiSegmentPredictionIntervalModel(FitAbstractModel, PredictIntervalAbstractModel, BaseMixin): | |||
There was a problem hiding this comment.
It seems we need just empty class without any implementation.
Downstream classes has implemented own logic already. Seems we can't share it
martins0n
suggested changes
Aug 10, 2022
etna/models/nn/tft.py
Outdated
| @@ -26,7 +26,7 @@ | |||
| from pytorch_lightning import LightningModule | |||
|
|
|||
|
|
|||
| class TFTModel(Model, PredictIntervalAbstractModel, _DeepCopyMixin): | |||
| class TFTModel(Model, MultiSegmentPredictionIntervalModel, _DeepCopyMixin): | |||
There was a problem hiding this comment.
We don't need Model here, I guess it's already in MultiSegmentPredictionIntervalModel?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting (must do checklist)
Proposed Changes
Closing issues
closes #768